hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

add llc4320 forcing files to catalog #306

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

I have transformed the forcing files into zarr from binary and are now available through Sciserver. I have added an entry on the intake catalog to load them when reading llc4320 data.

codecov[bot] commented 1 year ago

Codecov Report

Merging #306 (ec9d8db) into main (9c55efa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70           
Flag Coverage Δ
unittests 95.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

I don't understand the formatting error at all. When I run

pre-commit run --all

I get all passed. I reverse the changes but I don't think it triggered pre-commit to run again. Will make a change and reverse it, just to see if things change,

Mikejmnez commented 1 year ago

I removed the catalog entry and the error persisted. Again, running on my computer pre-commit run --all I don't ger any error, and all things pass.

Here is a snapshot of what it is:

error

I will approve the PR, since the error is not associated with the change to the catalog entry I made.

Will be on the lookout if this happens again. If so, will raise and issue and inspect it.

ThomasHaine commented 1 year ago

Thanks @Mikejmnez ! So the forcing files are now available through the regular open_oceandataset? And sea ice files?

Mikejmnez commented 1 year ago

Yes. All forcing files that we have for the 10 day test (hourly) LLC4320 data are available by doing

od = ospy.open_oceandataset.from_catalog('LLC4320')

The added variables are:

['oceFWflx', 'oceQnet', 'oceQsw', 'oceSflux', 'oceTAUX', 'oceTAUY', 'SIarea', 'SIheff', 'SIhsalt', 'SIhsnow', 'SIuice', 'SIvice', 'KPPhbl']

I will add the vertical velocity W soon too. In that case no PR will be needed.