search

hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

fix toml prettifier #307

Closed malmans2 closed 1 year ago

malmans2 commented 1 year ago

@Mikejmnez see: https://github.com/macisamuele/language-formatters-pre-commit-hooks/issues/133 It's not clear whether the project is actively maintained. We can also remove the hook, up to you.

codecov[bot] commented 1 year ago

Codecov Report

Merging #307 (6684388) into main (013fe97) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70
Flag Coverage Δ
unittests 95.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

Thanks @malmans2!

We can also remove the hook, up to you. Sure. Unless there is a reason to keep it, I'd remove it too.

Mikejmnez commented 1 year ago

Will wait until removing the hooks before merging

malmans2 commented 1 year ago

It just lints our toml files, so no big deal if you get rid of it.