Closed Mikejmnez closed 1 year ago
Merging #311 (5d55302) into main (b7fd442) will not change coverage. The diff coverage is
0.00%
.
@@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 9 9
Lines 3928 3928
Branches 850 850
=======================================
Hits 3761 3761
Misses 97 97
Partials 70 70
Flag | Coverage Δ | |
---|---|---|
unittests | 95.74% <0.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
oceanspy/plot.py | 97.52% <0.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I wasn't finished. Still missing a task (see first comment).
But these are minor issues with plotting and labels (ticks) not appearing unless add_labels
is set True manually as an argument intood.plot.horizontal_section()
Doh! Sorry about jumping the gun.
The goal of this PR is to close #310 . This PR accomplishes the following:
background_patch
withpatch
onParticles.ipynb
notebook.xlabels_top
bytop_label
andylabels_right
byright_labels
onospy.plot.horizontal_section()
.add_labels=True
as default argument inod.plot.horizontal_section
(and best way to do this), or to simply manually pass it as argument everytime one makes an horizontal section viaod.plot
module (for example, see cell 7 in https://oceanspy.readthedocs.io/en/latest/Kogur.html. Running this notebook as is on Sciserver does not plot the axis ticks nor labels).