hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

replace deprecated cartopy property on notebook #311

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

The goal of this PR is to close #310 . This PR accomplishes the following:

codecov[bot] commented 1 year ago

Codecov Report

Merging #311 (5d55302) into main (b7fd442) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines        3928     3928           
  Branches      850      850           
=======================================
  Hits         3761     3761           
  Misses         97       97           
  Partials       70       70           
Flag Coverage Δ
unittests 95.74% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/plot.py 97.52% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

I wasn't finished. Still missing a task (see first comment).

But these are minor issues with plotting and labels (ticks) not appearing unless add_labels is set True manually as an argument intood.plot.horizontal_section()

ThomasHaine commented 1 year ago

Doh! Sorry about jumping the gun.