Closed Mikejmnez closed 1 year ago
Merging #326 (b26a8ec) into main (6bb27b6) will decrease coverage by
0.05%
. The diff coverage is60.00%
.
@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 94.66% 94.62% -0.05%
==========================================
Files 9 9
Lines 3939 3942 +3
Branches 856 857 +1
==========================================
+ Hits 3729 3730 +1
- Misses 134 135 +1
- Partials 76 77 +1
Flag | Coverage Δ | |
---|---|---|
unittests | 94.62% <60.00%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
oceanspy/subsample.py | 97.70% <50.00%> (-0.35%) |
:arrow_down: |
oceanspy/llc_rearrange.py | 82.67% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Closes #323 (grid variables
XU, XV, YU, YV
are now available in the grid file). I checked having these grid variables pre-computed significantly speeds up the cutout function when transforming (lazily) the dataset.This PR also removes the velocity fields from the intake catalog. This is only temporary. I am combining all the zarr stores (within each single filedb volume) into a single one (see issue #324) . This is going to take the rest of the day. The final destination where all the data (within a single filedb node) will be stored will be where currently the velocity data lives. For that, and to avoid issues when reading LLC4320 data today, I am removing this entry (velocities) from the catalog.
Once the data has been written into a single zarr store, I will create another PR where I restore the entry associated with the velocities. In that PR (later today) all data will be in a single zarr store.