search

hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
98 stars 32 forks source link

Add daily mean ecco dataset to catalog #333

Closed MaceKuailv closed 1 year ago

MaceKuailv commented 1 year ago

Add the catalog for daily ecco

Mikejmnez commented 1 year ago

The error in CI you are getting is related to issue #332 , independent of the changes within this PR.

I got another fix for the issue in #332 , but I am having some trouble trying to install a testing environment in Sciserver to check that the error goes away. Mitya is helping me, hopefully will get a PR fixing issue #332 later today...

Mikejmnez commented 1 year ago

@MaceKuailv don't forget to run pre-commit to get all the formatting right

MaceKuailv commented 1 year ago

I am doing the pre-commit right now. I didn't realize that this part also have format constraints.

ThomasHaine commented 1 year ago

Thanks @MaceKuailv and @Mikejmnez! I'll make an announcement on https://www.poseidon-ocean.net/.