hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
96 stars 32 forks source link

set add_labels=True #337

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

closes #312

Mikejmnez commented 1 year ago

Working on this... On my computer all tests pass, but looking at the test_animate (horizontal_section) it does not produce the right FuncAnimation instance. I don't know why tests pass on my end... Shouldn't take me long...

codecov[bot] commented 1 year ago

Codecov Report

Merging #337 (0670d7e) into main (8f03f39) will increase coverage by 0.12%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   94.62%   94.75%   +0.12%     
==========================================
  Files           9        9              
  Lines        3944     3944              
  Branches      859      859              
==========================================
+ Hits         3732     3737       +5     
+ Misses        135      131       -4     
+ Partials       77       76       -1     
Flag Coverage Δ
unittests 94.75% <100.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/plot.py 98.65% <100.00%> (+1.12%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

It took me a bit... see issue #312 for the work around this issue!!!