Closed malmans2 closed 1 year ago
doh! Looks like the problem is matplotlib that is pinned to a quite old version. I guess we'll have to wait until #269 is resolved (cc @MaceKuailv that is working on #348).
The issue #269 is actually resolved. It is a kind of confusing situation. The pin we have now is for issue #349. We can relax the pin from "<3.5.2" to "<3.6.1". But to completely unpin, we need to work on issue 349, which is not going to be easy to do...
Seems like the error message is not related to any tests. It is something related to the building process.
Error: Failed to execute ["/home/runner/micromamba-bin/micromamba create -n oceanspy_test -y --log-level warning \"python=3.11\" -f /home/runner/work/oceanspy/oceanspy/ci/environment.yml"]: Error: The process '/home/runner/micromamba-bin/micromamba' failed with exit code 1
I am about to do some ci things for my package as well, I would love to work on this PR with you.
If you look a bit further up, you'll see:
error libmamba Could not solve for environment specs
The following packages are incompatible
├─ matplotlib <3.5.3 is installable with the potential options
Anyways, let's see if 3.6 is good enough. I'm going to merge main into this branch.
ohh I see, you did not change the pin yet. No rush, I'll leave this open and we'll try again 3.11 when the issue with matplotlib is sorted out. I'm moving this to draft PR.
@malmans2 I changed the pin to matplotlib in the last PR to 3.6.0, in case you want to give it another try to this PR
Main merged here. Let's see how it goes...
Same as before... Good to know though. I'm going take a look at #349 today so hopefully there is some quick fix
Matplotlib is now unpinned via PR #355
Merging #351 (8e8c803) into main (fb4cc96) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 9 9
Lines 3932 3932
Branches 858 924 +66
=======================================
Hits 3727 3727
Misses 129 129
Partials 76 76
Flag | Coverage Δ | |
---|---|---|
unittests | 94.78% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Green lights, merging!
Awesome!
I think we should be able to support python 3.11 now. Let's see if the CI is happy with 3.11.