hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
96 stars 32 forks source link

Compute accurately dist along array #361

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

While checking the issue #359, I realized I was computing the distance along an array wrong, and this PR corrects it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #361 (c05dafe) into main (954984d) will decrease coverage by 0.10%. The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   94.78%   94.68%   -0.10%     
==========================================
  Files           9        9              
  Lines        3932     3954      +22     
  Branches      924      933       +9     
==========================================
+ Hits         3727     3744      +17     
- Misses        129      132       +3     
- Partials       76       78       +2     
Flag Coverage Δ
unittests 94.68% <82.75%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/subsample.py 96.50% <82.75%> (-0.82%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Mikejmnez commented 1 year ago

This PR is not ready to be merged yet. I am working on still working on fixing the path of the array... (see #359)