hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
96 stars 32 forks source link

improved behavior of subsample.mooring #364

Closed Mikejmnez closed 1 year ago

Mikejmnez commented 1 year ago

Closes #362

It also improves the behavior of mooring (and cutout) when handling complex mooring array paths, which can cross the 0 or 180 degree longitude multiple times.

See for example the following arrays using the ECCO dataset (patterns were chosen from Poseidon viewer seen in top left):

examples
codecov[bot] commented 1 year ago

Codecov Report

Merging #364 (d7acc82) into main (cff27a3) will decrease coverage by 0.16%. The diff coverage is 90.66%.

@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
- Coverage   94.68%   94.53%   -0.16%     
==========================================
  Files           9        9              
  Lines        3954     3971      +17     
  Branches      933      943      +10     
==========================================
+ Hits         3744     3754      +10     
- Misses        132      137       +5     
- Partials       78       80       +2     
Flag Coverage Δ
unittests 94.53% <90.66%> (-0.16%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oceanspy/utils.py 86.89% <85.10%> (-1.71%) :arrow_down:
oceanspy/llc_rearrange.py 82.64% <100.00%> (-0.03%) :arrow_down:
oceanspy/subsample.py 96.50% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more