hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
96 stars 32 forks source link

update viewer2range to extract time range #408

Closed Mikejmnez closed 5 months ago

Mikejmnez commented 5 months ago

This PR closes: #407 and #405 . In specific, it does:

Usage:

from poseidon_viewer import get_shapes
import json
shapes = json.loads(get_shapes())
timeRange, lats, lons = viewer2range(shapes)
codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c7d4039) 96.79% compared to head (ca20c01) 96.63%.

Files Patch % Lines
oceanspy/utils.py 90.90% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #408 +/- ## ========================================== - Coverage 96.79% 96.63% -0.17% ========================================== Files 9 9 Lines 4987 4987 Branches 1189 1190 +1 ========================================== - Hits 4827 4819 -8 - Misses 90 96 +6 - Partials 70 72 +2 ``` | [Flag](https://app.codecov.io/gh/hainegroup/oceanspy/pull/408/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hainegroup/oceanspy/pull/408/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup) | `96.63% <90.90%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.