search

hainegroup / oceanspy

A Python package to facilitate ocean model data analysis and visualization.
https://oceanspy.readthedocs.io
MIT License
96 stars 32 forks source link

remove unnecessary definitions #418

Closed Mikejmnez closed 4 months ago

Mikejmnez commented 4 months ago

closes #417

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2432b16) 96.59% compared to head (7d25cc8) 96.59%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #418 +/- ## ======================================= Coverage 96.59% 96.59% ======================================= Files 9 9 Lines 4987 4987 Branches 1190 1190 ======================================= Hits 4817 4817 Misses 97 97 Partials 73 73 ``` | [Flag](https://app.codecov.io/gh/hainegroup/oceanspy/pull/418/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hainegroup/oceanspy/pull/418/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup) | `96.59% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hainegroup#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Mikejmnez commented 4 months ago

This is a very minor PR with no change to the base code. I will be approving and merging...

BTW the fact that all tests passed means the changes to yaml file are compatible with both version 2.0 and 0.7. Will be able to unpin Intake soon.