search

hairyone / TD5Tester

Land Rover TD5 engine diagnostic tool
Apache License 2.0
26 stars 7 forks source link

V2 version #3

Open td5gord opened 4 years ago

td5gord commented 4 years ago

Hello, unsure if you are still supporting this project but V2 crashes as soon as the apps opened but v1 seems to be ok! Is there much difference between the two?

Cheers for the brilliant app as well

theodosiskonia commented 3 years ago

Hello i am a programmer and i am interesting to continue with your project, are you positive to cooperate?

originalheff commented 3 years ago

i will fork the code and do some work on it. I am looking at adding some settings and changing metric to imperial etc

daycounts commented 3 years ago

I created a fork already with some improvements and additional ECU requests https://github.com/daycounts/TD5Tester This app should have more settings unit of measure for pressure, speed, temperature... Just not a good enough Android Developer to continue the work.

Aloike commented 3 years ago

Hi guys, I came to this project thanks to another French LR fanatic who tried to revive the project (he edited a few things, built an apk and put it on a LR Facebook group, "Land rover wallpapers"). We discussed a bit and I ended up working on the app. He wasn't using any CVS tool, so I imported his code, and I also did a few updates to the application.

I also have been in touch with @hairyone a few months ago. He told me that he wanted to return to the project but not found the time to. He gave us his blessing to continue working on his app and communicate about our progression.

What we've done so far:

Attached are a few screenshots of my development version on an emulator.

I created a Github organization to centralize new developments in a "community" way (although I didn't expect so many developers to be interested in this app!), and also to create some documentation for users. I haven't pushed my repo yet as I wanted to clean up a few things before sharing, but it keeps being postponed, so if anyone is interested in this, I can speed up the push.

I also hoped to publish the application on a store (as the organization, not myself ofc) as users frequently complain about installing from APKs.

Dashboard fragment:

Screenshot_1611280047

Intake fragment

Screenshot_1611280363

Fuel fragment

Screenshot_1611280368

Engine fragment

Screenshot_1611280772

Aloike commented 3 years ago

Oh I forgot... If anyone is interested in my current development version, attached is my apk.

Needless to say, it comes without any warranty/liability, use it at your own risks, not on public road, etc. etc.

Td5OpenDiag-dev-20210122.zip

hairyone commented 3 years ago

@Aloike does it make sense to add you as a collaborator to this project (you can then add other developers as you see fit) or would you rather manage your own fork?

Whilst I don't have a problem with lots of forks if people want to play around with the code, it seems that there ought to be one definitive resource where more people can collaborate.

Aloike commented 3 years ago

Hi @hairyone ,

Whilst I don't have a problem with lots of forks if people want to play around with the code, it seems that there ought to be one definitive resource where more people can collaborate.

I totally agree. For this reason I thought creating a "Github organization" was the way to go, because when you have a look at different repos, an organization tend to seems more "official" than a user's one, thus be more attractive to "lost" users. Also, if it's needed at some point, it allows to group several repositories, so if some people want to develop, say, a desktop tool to analyze logged data, or more realistically a documentation website, it might be more convenient to users. Also, on the development side, I remember organizations as being more flexible regarding the tools that allow users to synchronize their work (teams-based permissions, dashboards, no need to fork, ...).

@Aloike does it make sense to add you as a collaborator to this project (you can then add other developers as you see fit) or would you rather manage your own fork?

It's up to you ; my personal opinion would be to create an organization with all the contributors, but if you prefer to keep this repo as the official/main one, feel free to do so and I'll push my contributions here. :)

hairyone commented 3 years ago

Sounds good to me. I was not aware of the Organisation feature sounds like a better option.

On Fri, 22 Jan 2021, 11:07 Aloike, notifications@github.com wrote:

Hi @hairyone https://github.com/hairyone ,

Whilst I don't have a problem with lots of forks if people want to play around with the code, it seems that there ought to be one definitive resource where more people can collaborate.

I totally agree. For this reason I thought creating a "Github organization" was the way to go, because when you have a look at different repos, an organization tend to seems more "official" than a user's one, thus be more attractive to "lost" users. Also, if it's needed at some point, it allows to group several repositories, so if some people want to develop, say, a desktop tool to analyze logged data, or more realistically a documentation website, it might be more convenient to users. Also, on the development side, I remember organizations as being more flexible regarding the tools that allow users to synchronize their work (teams-based permissions, dashboards, no need to fork, ...).

@Aloike https://github.com/Aloike does it make sense to add you as a collaborator to this project (you can then add other developers as you see fit) or would you rather manage your own fork?

It's up to you ; my personal opinion would be to create an organization with all the contributors, but if you prefer to keep this repo as the official/main one, feel free to do so and I'll push my contributions here. :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hairyone/TD5Tester/issues/3#issuecomment-765327299, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSSYJVHYQ6BHV6L7U4VPB3S3FMALANCNFSM4M436QKA .

originalheff commented 3 years ago

@Aloike @hairyone I love this project and will happily collaborate , the work done so far is amazing.

I have minimal time as I have a day job, but i would like to add a number of features namely

  1. settings page
  2. Alarms and notifications
  3. adding in inclinometer gauges

Do you know if it is possible to read the switch values for

  1. DiffLock
  2. LowRatio

I would like to add visual and audible alarms for these as well. i.e. going over 10mph in DiffLock is not a great idea !

Regards John

hairyone commented 3 years ago

Hi John,

Gald you like it. I started on it years ago with a view to having a cheap / free version of a nanocom.

I started work on communicating with the wabco abs ecu but did not get very far.

I think inclinometer might be possible using the phone sensors.

Difflock and low range I'm not sure are available from the engine ecu. I cannot remember if they are available with the get_inputs pix.

It is good to see people getting involved. My enthusiasm for sitting in the car and debugging kinda dried up 😁

On Fri, 22 Jan 2021, 12:29 originalheff, notifications@github.com wrote:

@Aloike https://github.com/Aloike @hairyone https://github.com/hairyone I love this project and will happily collaborate , the work done so far is amazing.

I have minimal time as I have a day job, but i would like to add a number of features namely

  1. settings page
  2. Alarms and notifications
  3. adding in inclinometer gauges

Do you know if it is possible to read the switch values for

  1. DiffLock
  2. LowRatio

I would like to add visual and audible alarms for these as well. i.e. going over 10mph in DiffLock is not a great idea !

Regards John

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hairyone/TD5Tester/issues/3#issuecomment-765364765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSSYJSZZWRKDSNAFCENQ6TS3FVUFANCNFSM4M436QKA .

Aloike commented 3 years ago

As it seems like more and more people are interested in this project, i'll speed up the org creation and my code cleanup/push.

@originalheff Awesome! I like the idea of a "settings" page. I also thought about alarms but didn't work on it, I was thinking about inserting this as a gauge feature (but as nothing exists yet, it can still be anything else). Regarding inclinometer, that's an interesting feature too.

About switch values: There's no technical lock about that, but to my knowledge, the backend is missing. Switches are the feature I'd like to prioritize, as that's a major miss.

I too am a bit busy daily and Android is not a platform I have much experience on, but I hope to continue contributing to this project. Without much time to offer on its development, I restrained myself from exploring more "complex" features and tried to prioritize implementation of essential components, which are to my eyes sensors/values/DTC readings, and more broadly Nanocom-like features. It would be awesome to be able to provide a free & opensource system that goes beyound it ! :grinning:

I'd like to create a dedicated "issues" group in the organization to centralize features proposals/discussions/follow-ups.

Also, it feels like we should think about some UI improvements as some users complained about having too many informations they don't understand. I was thinking about having a "dashboard" activity with the essential information, then an "advanced" activity to display all inputs/outputs as a table, then other "specialized" activities like DTC read/clear, settings/connection management, etc. (to prepare for this I tried to move the interface management in a dedicated thread rather than having it in an activity, but it didn't went well for now) but that's another topic.

It's nice to see so many people onboard! :smiley:

Aloike commented 3 years ago

@hairyone For sure high/low switch is available on the ECU as it is used for fuel calculation. I don't remember about the diff lock, it might not be available.

It is good to see people getting involved. My enthusiasm for sitting in the car and debugging kinda dried up

And thanks to you there's now an awesome base available to everyone, May you be remembered and thanked many times by Td5 lovers (or at least owners :grin: ) for your contribution to the community.

EDIT: According to this page, the ECU indeed reads the High/Low switch (pin A33). And according to this page, "Illumination of the differential lock warning lamp (C0233) is controlled by differential lock unit (C0306) on a BU wire. When differential lock is selected, the switch contacts within the unit close creating a path to earth (C0307) on a B wire. Current from fuse 15 of the passenger compartment fuse box (C0580) is now able to flow across the bulb." So there's no way to know whether it's engaged or not.

originalheff commented 3 years ago

Oh I forgot... If anyone is interested in my current development version, attached is my apk.

Needless to say, it comes without any warranty/liability, use it at your own risks, not on public road, etc. etc.

Td5OpenDiag-dev-20210122.zip

looking forward to collaborating on this, one thing. the APK linked here does not install on Android 10, Will sort this out when you post to source . John

td5gord commented 3 years ago

I can't provide help with coding etc but I'm more then happy to beta test etc as I have an android set up in the car running a BMW cable using hairyones v1 APK for diag and on board info along side my nanocom!

Also have a fair few android devices on various android builds so can test on them if needed?

Keep up the good work fellas, certainly will be a highly helpfully tool when refined!

Get Outlook for Androidhttps://aka.ms/ghei36

From: originalheff notifications@github.com Sent: Saturday, January 23, 2021 11:06:21 AM To: hairyone/TD5Tester TD5Tester@noreply.github.com Cc: td5gord jord_honda@hotmail.com; Author author@noreply.github.com Subject: Re: [hairyone/TD5Tester] V2 version (#3)

Oh I forgot... If anyone is interested in my current development version, attached is my apk.

Needless to say, it comes without any warranty/liability, use it at your own risks, not on public road, etc. etc.

Td5OpenDiag-dev-20210122.ziphttps://github.com/hairyone/TD5Tester/files/5853265/Td5OpenDiag-dev-20210122.zip

looking forward to collaborating on this, one thing. the APK linked here does not install on Android 10, Will sort this out when you post to source . John

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/hairyone/TD5Tester/issues/3#issuecomment-765906164, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APQRZT37RZELAOEMHV3B3S3S3KUS3ANCNFSM4M436QKA.

bolo76 commented 3 years ago

Hello, I am the person who introduced the application to Aloike and a lot of td5 owners through social networks. I don't have any development skills, I just spend a little time tweaking and making cosmetic improvements during the first lockdown. I am attaching my google drive with the modified source code and different versions of applications. I will be very happy to join the project. https://drive.google.com/drive/folders/1oyFo4cSr4Hbt9-1Izrx1TSL6FxTZleCN?usp=sharing

hairyone commented 3 years ago

Thanks bolo76,

I think Aloike is planning to set up a new github project that is organisation based allowing more people to contribute.

Once this is set up I think we will have a hub where everyone to contribute.

On Thu, 28 Jan 2021, 21:09 bolo76, notifications@github.com wrote:

Hello, I am the person who introduced the application to Aloike and a lot of td5 owners through social networks. I don't have any development skills, I just spend a little time tweaking and making cosmetic improvements during the first lockdown. I am attaching my google drive with the modified source code and different versions of applications. I will be very happy to join the project. https://drive.google.com/drive/folders/1oyFo4cSr4Hbt9-1Izrx1TSL6FxTZleCN?usp=sharing

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hairyone/TD5Tester/issues/3#issuecomment-769396361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSSYJWAH7FMQYWWCSSRKP3S4HHBRANCNFSM4M436QKA .

bolo76 commented 3 years ago

Yes, we discussed it a bit. In any case, a big thank you for your project (about fifty landists also thank you in the world). With a wireless version we would cross the thousand ;)

originalheff commented 3 years ago

Great idea, I was thinking about this as well. Should not be too hard to do, will add this to the wish list when we get the github set up .

John

From: bolo76 notifications@github.com Sent: 28 January 2021 22:03 To: hairyone/TD5Tester TD5Tester@noreply.github.com Cc: originalheff johntaustin@hotmail.com; Mention mention@noreply.github.com Subject: Re: [hairyone/TD5Tester] V2 version (#3)

Yes, we discussed it a bit. In any case, a big thank you for your project (about fifty landists also thank you in the world). With a wireless version we would cross the thousand ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/hairyone/TD5Tester/issues/3#issuecomment-769428461, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO3XH7ABM3WWOZKOKDSAX2TS4HNIJANCNFSM4M436QKA.

Aloike commented 3 years ago

Hi guys, I'm sorry it took me so long to come back to you, I've been quite busy lately, unfortunately not that much on the app.

I've created the organization and added the source code into a new repo. I also batch-commited my local changes in the process. I've done that in a hurry to make it available quickly, so I hope I haven't made too many mistakes (my code is awful, I know :sweat_smile: ). I just verified I'm able to build from a fresh clone of the repo on my PC.

Please note that all changes are in the dev-master branch right now to keep master with a reference version, so you might want to git checkout dev-master to retrieve the last developments.

Here is the link to the organization: https://github.com/Td5OpenDiag

The repo is public so I guess anyone should be able to do pull requests.

Going to bed now, but feel free to send me a message if anything goes wrong. Aloha

originalheff commented 3 years ago

Hey

Grabbing a few hours to add some settings into the app, via the SettingsFragment Settings | Android Developershttps://developer.android.com/guide/topics/ui/settings and I have hit my first issue. I cannot manage to apply a Theme or style effectively to the fragment. This is an issue as the setting screen comes up with a dark background and dark text.. not very usable.

I have tried apply a custom/new theme & setting the layout, added a preferenceTheme in the style XMl Nothing works.

Any ideas ?

Style

Preference XML <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto"> <PreferenceCategory android:layout="?android:attr/preferenceLayoutChild" app:title="@string/logging_header">

    <SwitchPreferenceCompat
        android:theme="@style/Preference.PreferenceScreen"
        app:key="ExcelLogging"
        app:summaryOff="@string/ExcelLogging_off"
        app:summaryOn="@string/ExcelLogging_on"
        app:title="@string/ExcelLogging_title" />

    <ListPreference
        android:dialogTitle="@string/MeasurementUnitsDialogTitle"
        android:entries="@array/MeasurementUnits_titles"
        android:entryValues="@array/MeasurementUnits_values"
        android:key="MeasurementUnits"
        android:theme="@style/PreferenceScreen"
        android:title="@string/MeasurementUnitsTitle" />

</PreferenceCategory>

From: Aloike notifications@github.com Sent: 31 January 2021 23:48 To: hairyone/TD5Tester TD5Tester@noreply.github.com Cc: originalheff johntaustin@hotmail.com; Mention mention@noreply.github.com Subject: Re: [hairyone/TD5Tester] V2 version (#3)

Hi guys, I'm sorry it took me so long to come back to you, I've been quite busy lately, unfortunately not that much on the app.

I've created the organization and added the source code into a new repo. I also batch-commited my local changes in the process. I've done that in a hurry to make it available quickly, so I hope I haven't made too many mistakes (my code is awful, I know 😅 ). I just verified I'm able to build from a fresh clone of the repo on my PC.

Please note that all changes are in the dev-master branch right now to keep master with a reference version, so you might want to git checkout dev-master to retrieve the last developments.

Here is the link to the organization: https://github.com/Td5OpenDiag

The repo is public so I guess anyone should be able to do pull requests.

Going to bed now, but feel free to send me a message if anything goes wrong. Aloha

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/hairyone/TD5Tester/issues/3#issuecomment-770474232, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AO3XH7ECNE6MV3IGT3W4PFTS4XT4TANCNFSM4M436QKA.