search

haishanh / night-owl.vim

A 24bit dark Vim colorscheme based on sdras/night-owl-vscode-theme
499 stars 40 forks source link

DiffAdd, DiffChange, & DiffDelete Highlights #35

Closed pbnj closed 3 years ago

pbnj commented 3 years ago

The DiffAdd, DiffChange, and DiffDelete highlights today are defined such that the foreground color is #011627 (dark-blue-ish) and the background colors are Green, Yellow, and Red respectively.

This results in a less pleasing aesthetic than if the highlights were reversed (i.e. Green/Yellow/Red foreground and dark-blue background).

See Before/After screenshots below for reference.

The fix can be as simple as setting guifg to the value of guibg and setting guibg to NONE (and same for ctermfg & ctermbg) in colors/night-owl.vim, like so:

hi DiffAdd guifg=#addb67 ctermfg=149 guibg=NONE ctermbg=NONE gui=NONE cterm=NONE
hi DiffChange guifg=#ecc48d ctermfg=222 guibg=NONE ctermbg=NONE gui=NONE cterm=NONE
hi DiffDelete guifg=#ff5874 ctermfg=204 guibg=NONE ctermbg=NONE gui=NONE cterm=NONE

But I'm unsure if colors/night-owl.vim is being dynamically generated from another configuration file or not.

Before

Screen Shot 2020-12-21 at 9 21 42 PM

After

Screen Shot 2020-12-21 at 9 22 01 PM

I set my git gutter signs to U+2503

Would you be open for a PR for this? What are your thoughts?

haishanh commented 3 years ago

But I'm unsure if colors/night-owl.vim is being dynamically generated from another configuration file or not.

It is generated from another configuration file. But I plan to ditch that due to some limitations. So direct update on colors/night-owl.vim is acceptable to me.