haishanh / night-owl.vim

A 24bit dark Vim colorscheme based on sdras/night-owl-vscode-theme
501 stars 40 forks source link

Support for italic #7

Closed esviai closed 5 years ago

esviai commented 5 years ago

Hi there!

The theme is looking awesome! I wonder whether you have supported italic in the theme? Thanks.

haishanh commented 5 years ago

@renaissains It's supported, code comment is now using italic. But you will need a terminal (emulator) that support italic font, e.g. iTerm2 on macOS.

esviai commented 5 years ago

@haishanh Right, I've just noticed it, sorry I missed that. I was thinking about italicizing type and some other things. I've tried adding highlight htmlArg cterm=italic highlight Type cterm=italic in my vimrc, but it's not working.

haishanh commented 5 years ago

@renaissains First check if your terminal supports italic font or not with:

# run in your terminal
# you should see italic text if your terminal support it
echo -e "\e[3mtest\e[0m"

Then try to set gui also in Vim hightlight.

" in vimrc
highlight htmlArg gui=italic cterm=italic
esviai commented 5 years ago

Yes, it can support italic. But I haven't found a way to make the var in, let's say var a = 'string' to be italic.

I'm closing this issue as it is not related to your theme. Thank you for the help :+1:

haishanh commented 5 years ago

@renaissains You make need to fork this repo to create your own. I use the snippet on http://vim.wikia.com/wiki/Identify_the_syntax_highlighting_group_used_at_the_cursor to find the syntax name of a world under the cursor.