haiwen / seadroid

Android client for Seafile
Other
540 stars 277 forks source link

Downloading over previous file breaks significantly. #1022

Closed Rescue9 closed 2 weeks ago

Rescue9 commented 3 months ago

Downloading over a previous file in seadroid is broken. When trying to download over a previous file without deleting, it downloads about 50k worth of data, then says download is finished, but data is corrupted. I've tried various combinations of clearing the cache in the app, clearing the cache from the android apps settings, deleting the file manually via a file browser, etc.

I think this may be an issue with slow / poor network connections and keeping the security passwords. As I was sitting here writing out this bug, I couldn't get it to crash, but at work where I'm on LTE cell service, it crashes constantly.

Rescue9 commented 3 months ago

This is not an issue with slow networks. I've been dealing with this for weeks now. I'm finding this only happens in folders that have password protection. I've tried deleting the password, logging out of the Seafile account, manually deleting the file in a different app and re-downloading. Nothing is seeming to work.

Two things should be implemented: First, the ability to choose to save library passwords or not. If the app automatically saves passwords, then testing for problems is a pain because I always have to go to settings and clear the library password. Second, selecting Download Now should ALWAYS re-download the file; no checking if it exists, no checking if it's the same size, etc.... just download the file over the existing one. I can see managing file version clashes when clicking on the filename to re-download, but manually selecting Download Now is a conscious action to get the specific version that is on the server.

zhwanng commented 2 weeks ago

We've optimized some of the logic for this feature. However, we have not encountered and reproduced this issue, you can upgrade to the latest version