Push notifications support

haiwen / seadroid

Android client for Seafile

Other

530 stars 279 forks source link

Push notifications support #740

Open omkarnathsingh opened 6 years ago

omkarnathsingh commented 6 years ago

ios Seafile clients has push notifications support? Can we have the push notifications for Android client also using GCM/FCM?

shoeper commented 6 years ago

I doubt that it has push notifications.

What do you want to get pushed?

omkarnathsingh commented 6 years ago

ios commit: https://github.com/haiwen/seafile-iOS/commit/64b26c1afddb63297eedcd22d3654136a4352632

seahub commit: https://github.com/haiwen/seahub/commit/6b1144d7a47857f0fbe4862e0d5b763687d30c92

I would suggest to use push notifications for all the alerts/notifications which are mailed or appear in web client like

When someone shares me a file / directory
When I am added to a group
Chat mention maybe?

Thanks

shoeper commented 6 years ago

Ok, thanks. Didn't knew that. Still wondering where it is being configured because I'd expect sending push notifications on iOS require some sort of account / api key.

omkarnathsingh commented 6 years ago

It might be using Apple Notification as mentioned on Apple's developer website. For Android, FCM can be used under similar conditions, should I raise a issue on seahub repo also to support and add details for FCM and Android device registration?

shoeper commented 6 years ago

I think it is not needed. I currently do not develop for the Seafile project, but doubt that this will be addressed soon.

omkarnathsingh commented 6 years ago

Oh okay. This change will require server also to send connect to google servers and send alerts. Just doing in client will not help.