search

haiwen / seadroid

Android client for Seafile
Other
540 stars 277 forks source link

(feature request) Dark theme #990

Closed RenautMestdagh closed 5 months ago

RenautMestdagh commented 11 months ago

This has already been asked in #879 but since it's almost 3 years later, i thought i could ask this again. Are there any plans to implement a dark mode in the app? This would be really nice.

nixigaj commented 10 months ago

I agree. Dark mode would be really nice.

Rescue9 commented 10 months ago

Currently working on implementing this.

So far, I have a working theme switch based upon system settings, but the colors are wrong. I also want to implement a Force Dark Mode option in settings. While the toggle is there, it's currently non-functional. I'm working on fixing everything, but the code changes are extensive. I can see why the developer didn't want to bother with this. https://github.com/Rescue9/seadroid/wiki

zhwanng commented 10 months ago

@Rescue9

We are in the process of refactoring the Seadroid code. If possible, when the refactoring is complete, you can add the code for darkmode directly in the resource file.

Rescue9 commented 10 months ago

@zhwanng Is there a general timeframe on the completion of refactoring?

zhwanng commented 9 months ago

@zhwanng Is there a general timeframe on the completion of refactoring?

At present, we are in the process of reconstruction, and it is expected to be completed in one to two months.

DoS007 commented 9 months ago

Hi, just wondering: Isn't https://forum.seafile.com the appropriate place for feature requests. I thought github is only for bugs?

Rescue9 commented 9 months ago

This list explains what the GitHub issues section is for. https://github.com/haiwen/seadroid/labels

DoS007 commented 9 months ago

@Rescue9 So they both seem to be valid, forum and github for feature requests.

JScharloo commented 7 months ago

+1 for this