search

haiwen / seafile-client

Seafile desktop client.
http://seafile.com
Apache License 2.0
470 stars 280 forks source link

SSO Issue with Office 365 #1258

Open andres-asm opened 4 years ago

andres-asm commented 4 years ago

https://forum.seafile.com/t/problems-with-sso-and-office-365/10801/2

I’m having an issue with the desktop client and SSO. When I login thru a web browser with SSO I am redirected to this page:

image

But when I login via the client, I enter my seafile server URL and then what I get is this:

image

The view doesn’t render properly and as a result users can’t login. I copied the URL to a browser (another one just to test) and it worked fine, so it’s something with the web view.

How can we address this?

andres-asm commented 4 years ago

Update: it works fine on android:

image

andres-asm commented 4 years ago

@killing sorry to bother you, do you think this can be worked around? or should I switch to local users?

freeplant commented 4 years ago

I suggest you to switch to local users.

andres-asm commented 4 years ago

Gee that sucks honestly. https://seafile.gitbook.io/seafile-server-manual/deploying-seafile-under-linux/oauth-authentication

The implementation works fine in the web client and seadroid. There should be a way to fix this.

andres-asm commented 4 years ago

This is so discouraging...

HolySephi commented 4 years ago

Yeah we are having the same issue. Looks like the internal browser of the client (and seadrive-client) does not react to the redirection to the actual login-page.

HolySephi commented 3 years ago

fixed in client version 8 (currently beta)

NicolaiSchmid commented 3 years ago

A similar issue persists, Webauthn is still not supported.

The client shouldn't try and host its own browser. It should forward to the OS default browser and then set the redirect URI to a localhost server where the client is listening for the response. That way, the client doesn't have to maintain all the standards current browsers support for authentication and JavaScript.

killing commented 3 years ago

@NicolaiSchmid Thank you for your suggestion. We'll consider about it.