Open schmittlauch opened 2 years ago
What GitHub shows is the set of tags that contain the selected commit. For example, a few commits back it shows two latest tags: https://github.com/haiwen/seafile-client/commit/c9f91fcbde945f5ab246a839c0b10a58a3b68381
Thanks for the clarification @vcunat, confusing UI is confusing.
But the rest of my statement still holds, the hash in my initial packaging of the v8.0.7
tag still verifies when just building against the https://github.com/haiwen/seafile-client/commit/8b96abf64e6aa19e3beeff6b322bcd6d28120bdd commit.
My understanding is that it's already part of git design that tags aren't meant to be moved, which is (in my eyes) the main difference from branches.
Even worse, while https://github.com/haiwen/seafile-client/commit/8b96abf64e6aa19e3beeff6b322bcd6d28120bdd still builds fine against libsearpc 3.2.0, the retagged v8.0.7 seafile-client now fails at linking stage.
And building against the latest libsearpc tag v3.2-latest does not fix this linking failure, but only reduces the number of errors:
I allow myself the remark that from my experience, such -latest
tags have been regularly retagged in seafile repos and are thus not suitable for packaging anyways.
Is there a workaround for the linking failure? I'm facing this issue in Ubuntu Jammy. In Kinetic the build is successful.
Hello, when compiling the version after seafile client 8.0.7, please update your local libsearpc branch first to avoid link errors caused by libsearpc. In addition, before compiling the client, you need to compile and install the seafile daemon.
Dear @rumtid @feiniks, please do not modify the git tags of releases after publication, this makes life difficult for downstream packagers who sometimes pin and verify the hash of the sources they're building.
In this case, the tag v8.0.7 used to reference commit 8b96abf64e6aa19e3beeff6b322bcd6d28120bdd which I had packaged for nixpkgs/NixOS. Later, @feiniks changed that tag to point to 5077237d9d8fb98bda5f832c8844dec48e6f9877 instead. It'd be better to create another minor fix release like either 8.0.7.1, 8.0.7-1, or 8.0.8 instead of retroactively changing the tag.
Actually, after looking at the pages of both commits https://github.com/haiwen/seafile-client/commit/5077237d9d8fb98bda5f832c8844dec48e6f9877 and https://github.com/haiwen/seafile-client/commit/8b96abf64e6aa19e3beeff6b322bcd6d28120bdd it even looks like the same tag has been assigned twice? to different commits, at least both pages show the tag name below the commit.