search

haiwen / seafile-client

Seafile desktop client.
http://seafile.com
Apache License 2.0
462 stars 281 forks source link

macOS menu bar icons #1505

Closed davidrudlstorfer closed 5 months ago

davidrudlstorfer commented 6 months ago

Similar to #1269 I'd like to once again report about the menu bar icons in macOS within the Seafile drive client. Currently, Seafile is the only app I use which does not align with the remaining menu bar icons concerning the style.

Light Mode

Screenshot 2024-01-02 at 12 04 03

Dark Mode

Screenshot 2024-01-02 at 12 04 14

According to the latest macOS versions, the icon should stay white at all times and do not switch to black. Solutions would include to either let the user switch between different menu bar icons or update the icons to only use the white one.

Thanks in advance!

davidrudlstorfer commented 6 months ago

If I am not mistaken the logic regarding dark mode could be removed entirely as currently no distinction between the dark and light mode is made on macOS

https://github.com/haiwen/seafile-client/blob/189d1a48f4c75a0baaae2ea6e73d9c25087e117f/src/ui/tray-icon.cpp#L446C1-L474C71

killing commented 6 months ago

Thanks we'll look into this again.

davidrudlstorfer commented 6 months ago

I discovered one more thing - within the current macOS releases (Sonoma, Monterey) the system's menu bar icons actually depend on the background color.

Therefore, the optimal thing would be a toggle to individually choose the icon or get the icon color from the system in some way.

killing commented 5 months ago

This is fixed in https://github.com/haiwen/seafile-client/pull/1508