search

haiwen / seafile-docker

A Docker image for Seafile server
Other
544 stars 184 forks source link

Add EXPOSE 80 in Dockerfile #109

Closed tonito659 closed 5 years ago

tonito659 commented 5 years ago

Hi ! I'm using Seafile behind jwilder/nginx-proxy. This container binds to the docker socket and scans running containers to facilitate reverse-proxying them. But to automate it, it needs to know which ports are exposed by the container. Thoses ports are defined while building the image using EXPOSE (port number)

In addition this is good practice as it can help building on top of an image.

ohrensessel commented 5 years ago

As EXPOSE is given in the dockerfile of the pro version, I do not see any reason why it shouldn't be present in the normal version? came accross issue #28 and was wondering why it hasn't been merged...

freeplant commented 5 years ago

Fixed in https://github.com/haiwen/seafile-docker/pull/143

tonito659 commented 5 years ago

Thanks a lot !