search

haiwen / seafile-docker

A Docker image for Seafile server
Other
544 stars 184 forks source link

Support docker secrets #150

Closed darkdragon-001 closed 5 years ago

darkdragon-001 commented 5 years ago

Add environment variable SEAFILE_ADMIN_PASSWORD_FILE which reads the admin password from a file in order to support docker secrets. Also add examples to the README.md to suggest users to use this feature.

darkdragon-001 commented 5 years ago

Has this issue been addressed? I can't find anything in the documentation for seafile ce 7.0 -.-

renfeipeng commented 5 years ago

We have no plans to support this feature for the time being.

lcardito commented 3 years ago

Hey team!

I suppose this applies as well for the DB_ROOT_PASSWD? MariaDB clearly supports docker secrets (MYSQL_ROOT_PASSWORD_FILE), it is a shame that seafile doesn't..

Is there a workaround where we might be able to inject the secrets in the environment without having to change more logic? Perhaps extending the docker entrypoint in which we could read the file and export the value in the env?

I suppose it's up to the team the decision to support or not the feature.. however IMHO this issue/feature request should stay open for visibility 😞

Andy3153 commented 6 months ago

Unavailability of Docker Secrets is the only thing keeping me from using this program. I plan on publicly distributing my Docker configs and I won't just leave my password in the open. Plus, using envvars for passwords can easily become a security threat if someone gets access to the Docker container.

So, any news?