search

haiwen / seafile-docker

A Docker image for Seafile server
Other
536 stars 180 forks source link

Dockerfile: `acme.sh` should be upgraded after installation #370

Closed kirisakow closed 3 months ago

kirisakow commented 5 months ago

Problem

As the Seafile image evolves, I notice however that the version of acme.sh remains the same: v3.0.2 (while as of today the latest is v3.0.8). This goes against the official acme.sh documentation, which states:

acme.sh is in constant development, so it's strongly recommended to use the latest code.

Possible solution

Dockerfile should include instructions for upgrading acme.sh after installation. In other words, the command

https://github.com/haiwen/seafile-docker/blob/364840a5218348409400df2f4ada6c43bf41a703/image/seafile_11.0/Dockerfile#L53

should be 

cd /scripts/acme.sh && /scripts/acme.sh/acme.sh --install \
                    && /scripts/acme.sh/acme.sh --upgrade \
                    && ln -sf /root/.acme.sh/acme.sh /scripts/acme.sh/acme.sh