search

haiwen / seafile

High performance file syncing and sharing, with also Markdown WYSIWYG editing, Wiki, file label and other knowledge management features.
http://seafile.com/
Other
12.28k stars 1.54k forks source link

`seafile-ignore.txt` isn't powerful enough #2610

Open PerchunPak opened 2 years ago

PerchunPak commented 2 years ago

Currently, seafile-ignore.txt only supports * and ? wildcards. Furthermore, it works completely different from .gitignore.

The main problem is in uses of glib's glob pattern matching, which covers only basics. You should write your own function for pattern matching, which will work the same as .gitignore file because it's expected from the ignore file.

After my investigation, I found seaf_repo_check_ignore_file in daemon/repo-mgr.c, which looks like what I looked for. Unfortunately, I'm too bad in C, and I can't make requested here changes myself.

I also found few other issues with same proposes (#875, #762 and maybe some others) which were silently closed, I hope this feature request will not be the next?

whoisnobody commented 1 year ago

It would be great to have that functionality in seafile. Is it on the roadmap?

freeplant commented 1 year ago

We want to keep the ignore feature simple. So this feature is not in our roadmap.

PerchunPak commented 1 year ago

Why? It's so limited now. I can't even sync only one file, instead I need to ignore all files except one manually, and check if the program, that generate these files, don't add new on updates.

monotok commented 3 months ago

It is far too simple right now. Seafile is one of the few things that will sync my software development folder. However I want to ignore all hidden folders (build directories) except for .git and .idea folders. Currently it is impossible.

Please reconsider.

If I made the changes would it be accepted as a merge request as it is not on the roadmap?