[Improvement] Use plyr instead of Video.js on the download page

[doliG]

I propose to change the video player used in the preview page.

I got few bugs on the current one, and find it ugly and not user friendly to use. After few research, I find a player which looks lot better: Plyr.

Why ?

Pros:

• plyr support cool shortcuts out of the box (youtube like)
• plyr looks a lot better than Video.js
• plyr bundle is 3x smaller (31 kB vs 130.5 kB)
• plyr is customizable and can be branded with Seafile color, devil is in the details ;)

Cons:

• video.js has larger ecosystem (plugins, skins) since it has been around longer
• video.js is supported by a large video company

Resources

• Plyr demo
• Plyr doc

Final words

What do you think ? Good idea or useless feature ? Tell me, I'm open :)

[doliG]

Hello :wave: @caixiangyue @freeplant @killing @LeoSirius @lins05 @poetwang

[doliG]

Hello 👋 @caixiangyue @freeplant @killing @LeoSirius @lins05 @poetwang

Doing open source also means answer to users suggestions, and I see that most of issues openend here stay without answers.

Maybe I missed something, and there is a better way to contact you ?

Thanks.

[freeplant]

We think plyr is optimized for youtube, which is useless for us. We will keep using video.js

[doliG]

We think plyr is optimized for youtube

I think you misunderstood. Plyr is a video player which support youtube. But it's just a feature, as written in the first lines of Plyr docs.

It's an easy way to improve user experience and to reduce bundle. If you want I can create a PR this way you can test.

[freeplant]

As the JS file is only used in video view page, the size of the library is not important.