shaderprecomp: remove `ShaderSourceID`

hajimehoshi / ebiten

Ebitengine - A dead simple 2D game engine for Go

https://ebitengine.org

Apache License 2.0

11.02k stars 660 forks source link

shaderprecomp: remove `ShaderSourceID` #2999

Closed hajimehoshi closed 5 months ago

hajimehoshi commented 5 months ago

Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

What feature would you like to be added?

In the current specification, a ShaderSourceID might be different for different Ebitengine veresions. This is troublesome since a precompiled shader might use the ID for its filename. So, what about guaranteeing the algorithm of ID generations?

Why is this needed?

No response

hajimehoshi commented 5 months ago

Hmm, probably we should not expose the notion of 'ID'.

hajimehoshi commented 5 months ago

I realized that the struct ShaderSource is necessary in order to hide the source.