hajimehoshi / ebiten

Ebitengine - A dead simple 2D game engine for Go
https://ebitengine.org
Apache License 2.0
11.02k stars 660 forks source link

internal/ui: the canvas size is not initialized correctly when a GL context creation is delayed #3033

Closed hajimehoshi closed 4 months ago

hajimehoshi commented 4 months ago

Ebitengine Version

126af1420f8ac82feee4afc405e61e0efe18b9c7 (and probably v2.7.6)

Operating System

Go Version (go version)

go version go1.22.4 darwin/arm64

What steps will reproduce the problem?

This is tricky to reproduce. Create a game that takes a little long time at the fist Update, and upload the game to itch.io.

What is the expected result?

The canvas size is initialized correctly.

What happens instead?

The canvas size remains 16x16.

Anything else you feel useful to add?

From the code in internal/ui/ui_js.go actually there is a path where a canvas size is not initialized correctly.

This probably happens with 2.7. I'll backport the fix.

hajimehoshi commented 4 months ago

From the code in internal/ui/ui_js.go actually there is a path where a canvas size is not initialized correctly.

Hmm, is that true? The context seems always initialized before the main loop starts.

hajimehoshi commented 4 months ago

There should be a problem where a canvas size is not initialized correctly, but the cause should be different. I'll recreate another issue when I found the true culprit.