hajimehoshi / ebiten

Ebitengine - A dead simple 2D game engine for Go
https://ebitengine.org
Apache License 2.0
11.1k stars 665 forks source link

ebiten: retract `RunGameOptions.StrictContextRestoration` #3098

Closed hajimehoshi closed 2 months ago

hajimehoshi commented 2 months ago

Operating System

What feature would you like to be added?

RunGameOptions.StrictContextRestoration was introduced at #3083, but we realized that the current restoration implementation was not stable (though the code was the same as the previous one!), and perhaps just graceful shutting down for context losts (#3097) was enough in order to reduce ANR and crashes reported at the Play console.

We are now experimenting if the graceful-shutdown way would work well. If it works, I'll retract the option RunGameOptions.StrictContextRestoration before 2.8 is released. I don't remove the implementation of internal/restorable since possibly we might want to use it later in the future. If we don't need it for one year or so, we can remove internal/restorable again.

Why is this needed?

I don't want to add an uncertain thing to the public API.