Modules looking up macvendors.co over http and not https

hak5 / nano-tetra-modules

The Official WiFi Pineapple Module Repository for the NANO & TETRA

https://wifipineapple.com/modules

464 stars 143 forks source link

Closed pidgy closed 6 years ago

pidgy commented 6 years ago

No reason the URL containing mac address information should be seen by anyone sniffing your traffic.

macvendors.co also provides lookups over https which all modules should be using

            $url = "http://macvendors.co/api/" . $mac . "/JSON";

sebkinne commented 6 years ago

Good point, thanks!

I see you already submitted a PR, which we can accept after the off-topic change is removed.

Thank you!

sebkinne commented 6 years ago

Closed by #18.