search

hak5 / nano-tetra-modules

The Official WiFi Pineapple Module Repository for the NANO & TETRA
https://wifipineapple.com/modules
463 stars 143 forks source link

Update index.php #55

Closed H4xl0r closed 5 years ago

H4xl0r commented 5 years ago

fixed destination to support https and http

an0ma133 commented 5 years ago

@sebkinne please review and merge.

sebkinne commented 5 years ago

@foxtrot will take care of it. I no longer work for Hak5.

foxtrot commented 5 years ago

Hi,

If possible, I would like these two changes (#55 and #54) to be in one pull request, instead of being seperate. Please also remember to bump the module version by .1, in the module.json file.

H4xl0r commented 5 years ago

where is the problem ? just get both pulls or have a view on the changes (not big no bog deal) sorry but i am not the real owner of this project and i dont want to get it they should take the pulls for a better version , but its up to them if you need a version with both fixes just load from my rep .... they are both inculded

https://github.com/H4xl0r/EvilPortalNano

foxtrot commented 5 years ago

@H4xl0r I'm sorry if it came off like I wanted to disregard your PR - That isn't the case (It is still open). I simply asked if you could make the changes to the module with one pull request instead of two, and to increase the version number.

H4xl0r commented 5 years ago

no i wasn't offended all cool will see what i can do