hak5 / pineapple-modules

The Official WiFi Pineapple Module Repository for the WiFi Pineapple Mark VII
https://wifipineapple.com
368 stars 157 forks source link

[Evil Portal] Error restarting service after Client Authorized via Evil WPA #60

Closed Jman420 closed 1 year ago

Jman420 commented 1 year ago

The Evil WPA AP issues IP addresses in the range of 172.16.42.100. Once a client connects and authorizes through the Evil Portal the NAT assignment to allow the client past the Captive Portal is added and causes this check to always return true.

This prevents the Evil Portal service from being recognized as successfully stopped and also prevents it from being restarted.

Jman420 commented 1 year ago

Upon closer investigation I found that due to a trailing line break the stop service logic wasn't removing any Authorized Clients. I've drafted a fix here : https://github.com/hak5/pineapple-modules/pull/61

Jman420 commented 1 year ago

Fixes have been adopted in commit : https://github.com/hak5/pineapple-modules/commit/1022110fe23eae8a44ea7e53fb067eb7a5be4864