hakamadare / webservice-pushover

WebService-Pushover - Perl support for Pushover API
http://search.cpan.org/dist/WebService-Pushover
7 stars 6 forks source link

Use https API URL to allow use of non-creator user keys #1

Closed chizmw closed 10 years ago

chizmw commented 10 years ago

This works with existing keys AND allows non-creator keys to have messages published.

i.e. it resolves this error message

    {
        errors    [
            [0] "messages to users other than the creator of this application (E2P) must be sent over SSL to https://api.pushover.net/"
        ],
        request   "e0995xxxxxxxxxxxxxxxxxxxxxxxxxxx",
        status    0
    }

Test suite still passes:

➔ prove -lr t
t/00.load.t ................ 1/1 # Testing WebService::Pushover 0.1.2
t/00.load.t ................ ok
t/01.new.t ................. 1/3 # Testing instantiation of WebService::Pushover object
t/01.new.t ................. ok
t/02.methods.t ............. 1/1 # Testing 0.1.x methods
t/02.methods.t ............. ok
t/02.methods_deprecated.t .. 1/1 # Testing 0.0.x methods
t/02.methods_deprecated.t .. ok
t/03.spore.t ............... 1/2 # Testing instantiation of Net::HTTP::Spore object
t/03.spore.t ............... ok
t/pod-coverage.t ........... ok
t/pod.t .................... ok
All tests successful.
Files=7, Tests=10,  5 wallclock secs ( 0.05 usr  0.02 sys +  4.26 cusr  0.29 csys =  4.62 CPU)
Result: PASS
hakamadare commented 10 years ago

oh hey @chiselwright, i remember you from WebService::NotifyMyAndroid :) thanks!

hakamadare commented 10 years ago

regrettably, i cannot push a new release right now because PAUSE is down, but i assume at some point i'll be able to do so.

chizmw commented 10 years ago

No worries, I'm using a patched version locally. Thanks for merging.

It feels like I'm stalking you along your choice of notification service. :-)

hakamadare commented 10 years ago

well, for what it's worth, i haven't yet found anything i like better than Pushover, but if i do i'll let you know!

hakamadare commented 10 years ago

hooray, PAUSE is back up. WebService-Pushover-v0.2.0 released!