search

hakamadare / webservice-pushover

WebService-Pushover - Perl support for Pushover API
http://search.cpan.org/dist/WebService-Pushover
7 stars 6 forks source link

Throw exceptions on error? #3

Open pjf opened 10 years ago

pjf commented 10 years ago

I've just started using WebService::Pushover, and it's great. However one of my least favourite things in the world is checking return values; I'd much rather use a try/catch block to do error handling.

I'm happy to put forward some patches which add exceptions to WebService::Pushover, but I just want to make sure you're cool with that first. In an ideal world I'd love to see exceptions by default. (Although being the author of autodie, it's not surprising that's how I want things to work.)

Many thanks for a great module!

Paul

hakamadare commented 10 years ago

oh heck yeah, go for it.

i've been writing a bunch of Python and Ruby recently, so i've been thinking much more in terms of exceptions. be warned that i may steal your code patterns and reimplement them in my other Perl modules :)

-steve

pjf commented 10 years ago

Excellent! WebService::Pushover is a pretty core component of how I use exobrain, so I've got a strong investment in making it better. :)

Many thanks!

Paul

hakamadare commented 10 years ago

ok, exobrain looks AWESOME. i am delighted to contribute to the success of such a project!

would you be using Try::Tiny to implement exceptions? that would be my vague preference, since that module is already nicely packaged for all the platforms i regularly use (and thus for all the platforms for which i've packaged WebService::Pushover).

-steve

p.s. i'm also a big fan of HabitRPG :)

pjf commented 10 years ago

I was just looking at using 'die' to throw simple string exceptions. How people choose to catch them is entirely up to them, although I use Try::Tiny as well. So there should be no extra dependencies required.

As for HabitRPG, if you enjoy the website, you may also enjoy the hrpg cmdline client. I almost never use the website any more. ;)

pjf commented 10 years ago

Actually, this is a better hrpg tutorial.