search

hakanmhmd / MMM-Stock

Stock prices module for Magic Mirror
MIT License
15 stars 16 forks source link

Any chance you are still into fixing your module? #5

Closed Scardaddy closed 6 years ago

Scardaddy commented 6 years ago

Module has been broken for a while. Just wondering if you were interested in trying to fix it?

hakanmhmd commented 6 years ago

Hi, I fixed the api because yahoo finance was deprecated. I have pushed the code, however I get clientside error concerning the DOM. I am not really sure of the reason.

If you want to have a look and if you fix it send me a PR.

Scardaddy commented 6 years ago

I'll have a look tonight. Thanks for giving it some attention.

Scardaddy commented 6 years ago

You beat me to it. Thanks for putting in the effort, I know it wasn't easy. Quick question about the css. I am only able to get 4 tickers showing at once. How specifically are you supposed to manipulate the css, if you wanted to say add 10 tickers instead of 4. Assuming I already have the tickers implemented in the MM config file.

Thanks again,

On 21 November 2017 at 04:53, Hakan notifications@github.com wrote:

Closed #5 https://github.com/hakanmhmd/MMM-Stock/issues/5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hakanmhmd/MMM-Stock/issues/5#event-1351915379, or mute the thread https://github.com/notifications/unsubscribe-auth/AYbo5t4ef-ONUjEvYvLdXYOs1gElYUopks5s4sfjgaJpZM4QjHQ5 .

hakanmhmd commented 6 years ago 
0%   {margin-top: 0}
10%  {margin-top: -30px}
20%  {margin-top: -60px}
30%  {margin-top: -90px}
40%  {margin-top: -120px}
50%  {margin-top: -150px}
60%  {margin-top: -180px}
70%  {margin-top: -210px}
80%  {margin-top: -240px}
90%  {margin-top: -270px}
100% {margin-top: 0}

I think this should do it. If might see parts of the previous ticker from above or below. To fix that play with the line height of each ticker. You could remove the padding too