hakanuzunoglu / TWF-Dash

TWF Dashboard Ecosystem. A family of 8 feature-packed non-replica dashboards custom made for different use cases that will probably make you race faster and safer.
36 stars 0 forks source link

Lap review pop in race #2

Closed Weshtrotinette closed 1 year ago

Weshtrotinette commented 1 year ago

I think choosing lap review should only appear when practice and qualify.

The reason i think this is it give so much informations and can't use this in race

I have modified your widget Fx by using the "Lovely dashboard script" as :

const json_settings = readtextfile('./JavascriptExtensions/Lovely-Dashboard_settings.json') const settings = JSON.parse(json_settings);

if ( !settings ) { lapReview = 1 lapReviewDelay = 5000 } else { lapReview = settings.lapReview lapReviewDelay = settings.lapReviewDelay }

if ( $prop('DataCorePlugin.GameData.CompletedLaps') > 1 && $prop('DataCorePlugin.GameRawData.Graphics.iCurrentTime') < lapReviewDelay && $prop('DataCorePlugin.GameRawData.Graphics.iCurrentTime') != 0 ) {

if ( lapReview == 2) {
    // Always On
    return 1
} else if (lapReview == 1) {
    // Quali Only
    if ( 
        $prop('DataCorePlugin.GameData.SessionTypeName')=='QUALIFY' || 
        $prop('DataCorePlugin.GameData.SessionTypeName')=='PRACTICE' 
    ) {
        return 1
    } else {
        return 0
    }
} else {
    // Always Off
    return 0
}

} else {

return 0

}

Not sure all the script is needed but it works fine !

Thanks

hakanuzunoglu commented 1 year ago

I can introduce a setting to choose on which sessions lap reviews appear

On Fri, 14 Apr 2023, 5:01 pm Weshtrotinette, @.***> wrote:

I think choosing lap review should only appear when practice and qualify.

The reason i think this is it give so much informations and can't use this in race

I have modified your widget Fx by using the "Lovely dashboard script" as :

const json_settings = readtextfile('./JavascriptExtensions/Lovely-Dashboard_settings.json') const settings = JSON.parse(json_settings);

if ( !settings ) { lapReview = 1 lapReviewDelay = 5000 } else { lapReview = settings.lapReview lapReviewDelay = settings.lapReviewDelay }

if ( $prop('DataCorePlugin.GameData.CompletedLaps') > 1 && $prop('DataCorePlugin.GameRawData.Graphics.iCurrentTime') < lapReviewDelay && $prop('DataCorePlugin.GameRawData.Graphics.iCurrentTime') != 0 ) {

if ( lapReview == 2) { // Always On return 1 } else if (lapReview == 1) { // Quali Only if ( $prop('DataCorePlugin.GameData.SessionTypeName')=='QUALIFY' || $prop('DataCorePlugin.GameData.SessionTypeName')=='PRACTICE' ) { return 1 } else { return 0 } } else { // Always Off return 0 }

} else {

return 0

}

Not sure all the script is needed but it works fine !

Thanks

— Reply to this email directly, view it on GitHub https://github.com/hakanuzunoglu/TWF-Dash/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCEAFVKJK4XBIWDRVB5GVDXBFDA7ANCNFSM6AAAAAAW6MT2WY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hakanuzunoglu commented 1 year ago

Also, glad you were able to fix it that way. I also have received feedback to add even more info on the review, including sectors. So, in terms of the amount of information, I will keep the designs as is but will think of introducing more settings for lap reviews in the future.