hakaru-CS4ZP6 / hakaru

A probabilistic programming language
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Poster Discussion #32

Closed mkhattab940 closed 6 years ago

mkhattab940 commented 6 years ago

Latest poster can be found in the following repo: https://github.com/hakaru-CS4ZP6/Hakaru-Poster/tree/master

@staplejw can you push up the latest compiled poster.pdf before assigning Dr. Carette to this issue?

staplejw commented 6 years ago

I have pushed the latest pdf version of the poster. I am curious to hear everyones thoughts and critiques. Compared to a lot of the other posters that I have seen from groups in our class, we have a lot of text. This is becoming a problem because we are running out of room on the poster yet still have things to add. @maymoo99 and I were talking about removing the section on implementing distributions via PDF/PMF. However, this is the section that contains Hakaru code, and I think it is important to have some Hakaru code somewhere on the poster. Ideas on where else that could be included?

mkhattab940 commented 6 years ago

TBH, that hakaru code in particular isn't great since it isn't representative of the majority of the code we're writing anyways. Needing to resort to PDF/PMF is a border-line fringe case when it comes to stdlib development and it is irrelevant to test case writing. So, yeah, I think it's fine to nuke the whole section and save that information for the paper where more in-depth discussion is warranted.

I think instead we should show 2 example distribution implementations one of each form discussed, maybe tuck them under the formal transformation definition. Also, let's use screenshots directly from sublime to show off the syntax-highlighting.

In the meantime I'll branch off and start paring down the rest of the text.

JacquesCarette commented 6 years ago

Yeah, way too many words. Sometimes you can just be more succinct by rephrasing. And, on posters, you frequently don't need complete sentences. And you want to illustrate things with more visual items -- pictures, code, diagrams, etc. You do have some nice ones, you should strive for more.

JacquesCarette commented 6 years ago

I'm going to email 2 sample posters to give you an idea.

JacquesCarette commented 6 years ago

Ok, I've emailed them to Justin, as I don't seem to have anyone else's email!!

mkhattab940 commented 6 years ago

Suggestion for another picture to include: we could show the histrogram script results next to the PDF curves for a distribution that can take on a wide range of shapes depending on its parameters. Show 3 in a row in single figure. Talk a bit about how we used it to visually verify stdlib correctness.

staplejw commented 6 years ago

@maymoo99 I have addressed some of the comments that you made in your most recent commit to the poster repo. Here are my thoughts on each section:

mkhattab940 commented 6 years ago

@staplejw

sohraa3 commented 6 years ago

@maymoo99 @staplejw I have made some modifications on the poster but before going further, I wanted to discuss the following points with you.

mkhattab940 commented 6 years ago

@sohraa3 I disagree about not including an intro about statistics. Those are grad level projects and we're undergrads and we have to keep in mind the difference of our audience

hk-maple is an inference algorithm according to the front page of the documentation: http://hakaru-dev.github.io/#transformations

I like the idea of splitting up the intro. You want to tackle that?

You're right about the second formula being wrong, but we definitely need Y. @staplejw it should be: X ~ dist_A(p) => Y ~ dist_B(q,X) = dist_C(p,q)

staplejw commented 6 years ago

I made a bunch of changes.

This code was pushed on mahmoud's branch. @sohraa3 I don't think the section on implementing the distributions via PDF/PMF is that important. Our poster already has a ton of content and we can afford to cut some. I feel that the intro is important because it makes our project more accessible and that is largely what we are being evaluated on.

JacquesCarette commented 6 years ago

When is this due? What exactly do you expect me to do on this, by when?

christopheranand commented 6 years ago

It is past due, but without penalty. 

The TAs and I have been giving extensive comments, and other groups have made several iterations. But they need to present it to graduate!

Sent from my iPhone

On Mar 29, 2018, at 1:28 PM, Jacques Carette notifications@github.com wrote:

When is this due? What exactly do you expect me to do on this, by when? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

staplejw commented 6 years ago

We have planned on having a draft done by the end of the day today so that we can submit it to the TA's and Dr. Anand for critiques. @JacquesCarette, could you also provide some brief critiques? Preferably by the end of tomorrow?

JacquesCarette commented 6 years ago

Feedback: the content and organization of the poster is very good. What was chosen to be shown is very representative of the work being done.

The poster itself could be improved by having a lot fewer words (and more pictures / code / etc) to communicate the same content.

JacquesCarette commented 6 years ago

@staplejw in #39 mentions "With the poster out of the way". Does that mean it is time to close this issue?

staplejw commented 6 years ago

Yes, this is a very recent development.