hakaru-dev / hakaru

A probabilistic programming language
BSD 3-Clause "New" or "Revised" License
309 stars 30 forks source link

Cauchy test 3 #190

Open staplejw opened 6 years ago

staplejw commented 6 years ago

Failure in: 6:RoundTrip:7:3:t_cauchy_reciprocal_transformation:0 haskell/Tests/TestTools.hs:130 expected: stdNormal = p <~ normal(nat2real(0), nat2prob(1)) return p stdCauchy = X1 <~ stdNormal X2 <~ stdNormal return X1 / X2 cauchy = fn a real: fn alpha prob: X <~ stdCauchy return a + prob2real(alpha) X X <~ cauchy(nat2real(0), 1/2) return X but got: p5 <~ normal(+0/1, 1/1) p3 <~ normal(+0/1, 1/1) return p5 / p3 (+1/2) Cases: 338 Tried: 293 Errors: 2 Failures: 26

Failure in: 6:RoundTrip:7:3:t_cauchy_reciprocal_transformation:1 haskell/Tests/TestTools.hs:130 expected: stdNormal = p <~ normal(nat2real(0), nat2prob(1)) return p stdCauchy = X1 <~ stdNormal X2 <~ stdNormal return X1 / X2 cauchy = fn a real: fn alpha prob: X <~ stdCauchy return a + prob2real(alpha) X X <~ cauchy(nat2real(0), 1/2) return X but got: p5 <~ normal(+0/1, 1/1) p3 <~ normal(+0/1, 1/1) return 1/ p5 p3 * (+1/2) Cases: 338 Tried: 294 Errors: 2 Failures: 27 Cases: 338 Tried: 295 Errors: 2 Failures: 27 Cases: 338 Tried: 296 Errors: 2 Failures: 27 Cases: 338 Tried: 297 Errors: 2 Failures: 27

mkhattab940 commented 6 years ago

Done in-lining. Failure looks like this now

### Failure in: 6:RoundTrip:0:2:t_cauchy_reciprocal_transformation:1
haskell/Tests/TestTools.hs:130
expected:
X1 <~ normal(+0/1, 1/1)
X2 <~ normal(+0/1, 1/1)
return X1 / X2 * (+1/2)
but got:
p5 <~ normal(+0/1, 1/1)
p3 <~ normal(+0/1, 1/1)
return 1/ p5 * p3 * (+1/2)
Cases: 164  Tried: 89  Errors: 0  Failures: 5
Cases: 164  Tried: 90  Errors: 0  Failures: 5
mkhattab940 commented 6 years ago

OK fixed