hakaru-dev / hakaru

A probabilistic programming language
BSD 3-Clause "New" or "Revised" License
310 stars 30 forks source link

Cauchy test 6 #193

Open staplejw opened 6 years ago

staplejw commented 6 years ago

Failure in: 6:RoundTrip:7:2:t_uniform_to_cauchy:0

haskell/Tests/TestTools.hs:130 expected: stdNormal = p <~ normal(nat2real(0), nat2prob(1)) return p stdCauchy = X1 <~ stdNormal X2 <~ stdNormal return X1 / X2 cauchy = fn a real: fn alpha prob: X <~ stdCauchy return a + prob2real(alpha) * X cauchy(nat2real(0), nat2prob(1)) but got: p5 <~ normal(+0/1, 1/1) p3 <~ normal(+0/1, 1/1) return p5 / p3 Cases: 342 Tried: 297 Errors: 2 Failures: 29

Failure in: 6:RoundTrip:7:2:t_uniform_to_cauchy:1

haskell/Tests/TestTools.hs:130 expected: stdNormal = p <~ normal(nat2real(0), nat2prob(1)) return p stdCauchy = X1 <~ stdNormal X2 <~ stdNormal return X1 / X2 cauchy = fn a real: fn alpha prob: X <~ stdCauchy return a + prob2real(alpha) X cauchy(nat2real(0), nat2prob(1)) but got: X3 <~ uniform(+0/1, +1/1) return tan(prob2real(pi) (X3 + (-1/2))) Cases: 342 Tried: 298 Errors: 2 Failures: 30 Cases: 342 Tried: 299 Errors: 2 Failures: 30 Cases: 342 Tried: 300 Errors: 2 Failures: 30 Cases: 342 Tried: 301 Errors: 2 Failures: 30

mkhattab940 commented 6 years ago

@JacquesCarette Just, FYI I am going through @staplejw 's and @NevinM14 's pull requests right now to see what 0-test failures can be solved by in-lining.

JacquesCarette commented 6 years ago

Ok. And while you're at it, can you try to submit PRs that don't have to be hand-merged? It is super-tiresome...