search

hakaru-dev / hakaru

A probabilistic programming language
BSD 3-Clause "New" or "Revised" License
310 stars 30 forks source link

Passing over ownership of my Syntax Highlighting package #201

Open mkhattab940 opened 6 years ago

mkhattab940 commented 6 years ago

https://github.com/hakaru-CS4ZP6/Syntax-highlighting-for-hakaru

So, my team and I are wrapping up our capstone project. Over the course of the project, I made a Syntax highlighting package for Sublime (linked above). It has been extremely useful for us and it would be great to see it used as Hakaru continues to develop. As it stands, I think it's the only syntax highlighting available for a GUI based text editor.

What's the best way to pass this off?

JacquesCarette commented 6 years ago

@ccshan @zaxtax I think it's a good idea to have syntax highlighting for various editors packaged up with Hakaru. My main questions are (assuming you agree)

Opinions?

zaxtax commented 6 years ago

There is a tools/ directory in the repo for vim and emacs syntax highlighting. It would be marvellous if it was added there!

On Wed, Apr 25, 2018, 23:46 Jacques Carette notifications@github.com wrote:

@ccshan https://github.com/ccshan @zaxtax https://github.com/zaxtax I think it's a good idea to have syntax highlighting for various editors packaged up with Hakaru. My main questions are (assuming you agree)

  • where to store them in the hierarchy?
  • how to "take ownership" of this? [i.e. it would be nice to keep the git history while still moving it over]

Opinions?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hakaru-dev/hakaru/issues/201#issuecomment-384457426, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAhUSRABztR-Y3Xioyy_PcsbL57Lyibks5tsPy1gaJpZM4TirC0 .

JacquesCarette commented 6 years ago

Ok, will do. Actually, maybe the easiest would be for @maymoo99 to submit a PR, that way we could preserve the git history?

mkhattab940 commented 6 years ago

Wilco. May have to wait a couple weeks when I get back from my travels as I don't have my laptop. Sooner if I make it to an Internet cafe somewhere

JacquesCarette commented 6 years ago

No problem, we're patient!