If solving phase is not correctly detected, solving cube does not stop timer

hakatashi / smart-cube-timer

Proof-of-concept smart timer for GiiKER

https://hakatashi.github.io/smart-cube-timer/

MIT License

72 stars 22 forks source link

If solving phase is not correctly detected, solving cube does not stop timer #21

Open PSzczepanski1996 opened 5 years ago

PSzczepanski1996 commented 5 years ago

Ok, so if I use different solution - for example own algorithm not used by many speedcubers, odd combinations of algs to solve OLL 2-LL (yeah, I am used to it) it get stuck on certain phase (F2L/OLL) and even if cube is solved, timer does not stop.

I recommend not depending on phases or add second "virtual cube" or other solution to avoid that. Sometimes also my solutions are detected as Roux (rarely) - I'm fridich user.

hakatashi commented 5 years ago

This is strange. I thought I programmed this timer to always stop when the cube is solved.

Give me an example of solve that reproduces this bug please?

hugopeeters commented 5 years ago

I think I only have this issue at the start of a session, when Roux is detected instead of CFOP. After resetting, it stays out of sync for a few solves. Maybe the reset button will fix this. I’ll keep my eye out for the issue and submit examples.