Use extra lyrics providers

[Kabouik]

Thanks a lot @hakerdefo for the test script you sent me by email. I am replying here instead of email since I guess others may want to comment future progress.

I have tested it a bit, but I'm getting an issue, I guess when no lyrics are found:

cmus-lyrics
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 422: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 423: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 424: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 422: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 423: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 424: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 422: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 423: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 424: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 422: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 423: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
/usr/local/bin/cmus-lyrics: line 424: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
cat: /tmp/cmus_lyrics//lyrics_found///tmp/cmus_lyrics//88f272d58dd314f6bd5dfee5f521f57c2acfdfdda69e579d1d7f293180fbf78e: No such file or directory
^C

Also, if I understood correctly, you added added support for glyr (with a facultative dependency), right? I don't have it installed on my laptop right now, which may be why there's an issue on my machine that you didn't notice on yours.

[hakerdefo]

@Kabouik I've updated cmus-lyrics and the issues noticed by you should hopefully disappear now. cmus-lyrics should work fine without Glyr and a couple of extra dependencies but installing them will definitely increase the chances of finding the lyrics.

Cheers!!!

[Kabouik]

Sorry if took me some time to test. I think you did indeed succeed the bug, thanks a ton! That's awesome. I'll test it some more of course to make sure there's no other issue showing up, but if that's the case I'll report back.

Can you elaborate on what is the list of the new lyrics providers now and how they are fetched without the glyr dependency? Is it all based on bash?

[Kabouik]

Oh, checking the commit I noticed you updated the README with that information!