hakimel / Fokus

MIT License
625 stars 87 forks source link

Scroll #2

Closed matthewlein closed 12 years ago

matthewlein commented 12 years ago

When you scroll, the box stays where the selected element was. The box should stay over the original element, or unfokus.

Cool idea, just want to make it better.

hakimel commented 12 years ago

In which browser and on which site was this? I've been trying it on a couple of sites with vertical scroll and the cut-out moves along with the selected element when scrolling.

matthewlein commented 12 years ago

Yea sorry wasn't very thorough in my bug. Safari 6.0 does it on your site.

Another thing, in chrome the elastic scroll past the page top makes it move off the element, but then springs back to the correct spot.

hakimel commented 12 years ago

Just gave Safari 6 a go and not seeing it there either :/

Good point about the elastic scroll, will add a lower limit of 0 for the scroll offset.

matthewlein commented 12 years ago

weird, here's what it looks like when I scroll

notice the blue highlight is off. And if I keep scrolling it stays in the same location relative to the window, not the element.

kopepasah commented 12 years ago

Scroll works fine for me in Safari 6 as well.

hakimel commented 12 years ago

Re-tested this on another computer with Safari 6 and it worked there as well. Have no idea why that's happening for you.

matthewlein commented 12 years ago

Was safari 6.0. Got 6.0.1 last night and now its fixed :)

hakimel commented 12 years ago

Still strange since I'm on 6.0 but glad to hear it's working for you now :)