hakimel / reveal.js

The HTML Presentation Framework
https://revealjs.com
MIT License
67.62k stars 16.63k forks source link

uglify build step fails on master #1179

Closed lvh closed 9 years ago

lvh commented 9 years ago
~/P/reveal.js: git checkout origin/master                                                                                                                                                           18:25:07
HEAD is now at 8858ee7... note about plugins
~/P/reveal.js: npm install                                                                                                                                                                          18:25:10
~/P/reveal.js: grunt                                                                                                                                                                                18:25:16
Running "sass:core" (sass) task
File css/reveal.css created.

Running "sass:themes" (sass) task
File css/theme/white.css created.
File css/theme/black.css created.
File css/theme/league.css created.
File css/theme/beige.css created.
File css/theme/serif.css created.
File css/theme/night.css created.
File css/theme/simple.css created.
File css/theme/sky.css created.
File css/theme/moon.css created.
File css/theme/solarized.css created.
File css/theme/blood.css created.

Running "autoprefixer:dist" (autoprefixer) task
File css/reveal.css created.

Running "cssmin:compress" (cssmin) task
File css/reveal.min.css created.
Warning: Cannot assign to read only property 'subarray' of /*!
 * reveal.js
 * http://lab.hakim.se/reveal-js
 * MIT licensed
 *
 * Copyright (C) 2015 Hakim El Hattab, http://hakim.se
 */ html,body,.reveal div,.reveal span,.reveal applet,.reveal object,.reveal iframe,.reveal h1,.reveal h2,.reveal h3,.reveal h4,.reveal h5,.reveal h6,.reveal p,.reveal blockquote,.reveal pre,.reveal a,.reveal abbr,.reveal acronym,.reveal address,.reveal big,.reveal cite,.reveal ...
(snipped for brevity)

Aborted due to warnings.

I googled, found an issue that suggested updating grunt-contrib-uglify to 0.8.0. Worked for them, not for me.

Delapouite commented 9 years ago

No problem for me on node v0.10.38. What is your version @lvh?

lvh commented 9 years ago
~/P/reveal.js: npm --version                                                                                                                                                                        09:33:55
2.7.3
~/P/reveal.js: node --version                                                                                                                                                                       09:33:57
v0.12.1
lvh commented 9 years ago

Found the issue with some digging. Wasn't in uglify, but cssmin:

-    "grunt-contrib-cssmin": "~0.4.1",
+    "grunt-contrib-cssmin": "~0.12.2",

... fixed the issue. Should I submit a PR to update both? I've found some other issues that people might run in to due to the other dependency being outdated.

hakimel commented 9 years ago

I didn't have any problem with this either but I've upgraded cssmin to 0.12.2 so that no one else runs into this. Thanks for the fix.

meatflavourdev commented 9 years ago

Thank you!!!!