hakimel / reveal.js

The HTML Presentation Framework
https://revealjs.com
MIT License
67.91k stars 16.65k forks source link

The `package` task removes the top-levels of folders included through globs #2825

Open bauglir opened 4 years ago

bauglir commented 4 years ago

The code specifying the package task:https://github.com/hakimel/reveal.js/blob/0582f57517c97a4c7bfeb58762138c78883f94c5/gulpfile.js#L250-L257 Grabs all the files from dist, plugin, etc. and puts them in the root of the created zip (i.e. without the dist, plugin, etc.). This causes the links to these files from the index.html to be broken.

I'm not sure if I'm missing something else that would be used for rewriting those links in the index.html, but adding { base: '.' } as the second argument to gulp.src (conform https://github.com/gulpjs/gulp/issues/151#issuecomment-41508551) addresses the issue and puts the files where the index.html expects them.

josefheidler commented 3 years ago

Lets push it!