hakimel / reveal.js

The HTML Presentation Framework
https://revealjs.com
MIT License
68k stars 16.65k forks source link

Pug templates support #3274

Open unrealsolver opened 2 years ago

unrealsolver commented 2 years ago

As an experienced web developer and revealjs user, I want to have:

All of these is achievable with pug templates. See https://pugjs.org

Martinomagnifico commented 2 years ago

It is probably out of the scope of Reveal.js. This PR only works through Gulp in the "Full Setup" installation. It won't work in the "Basic setup" or NPM installation. So the PR is more of a change in the build setup than a change in Reveal.js itself.

Any developer can adjust the gulpfile to add Pug support (I do it as well, I prefer writing Pug compared to HTML, the same as I prefer writing SCSS to CSS), but that still does not change Reveal itself. So the proposed text change "The framework comes with […] Pug templates support […]" would not be accurate.

unrealsolver commented 2 years ago

@Martinomagnifico, make sense. I removed changes in README. Though, I agree that any developer can adjust gulpfile, but I am not sure that any developer would adjust it, so I think this small change still make sense.

Martinomagnifico commented 2 years ago

Hi @unrealsolver, It's up to anyone to choose their Gulp setup, and developers who want to choose a certain engine or any flow improvement, will know how to do that. If you want Reveal to add it, then the same logic would then go for every template language out there. I appreciate your effort, but I don't think @hakimel will do that. I guess if you have a nice setup for presentations that works well, you can add it as a reveal-pug-starter project on Github, so that people can start from that as well.

Martinomagnifico commented 2 years ago

Hi @unrealsolver, I made a project here: Reveal-pug-scss-starter. Feel free to fork it, add stuff to it, PR changes etcetera.

Martinomagnifico commented 2 years ago

@unrealsolver can we close this issue? It's really something out of the scope of Reveal.js.