hako-975 / PHPExcel-v7.4

New Version PHPExcel for PHP 7.4 up Let's Clone this repo for free If you find a bug, don't hesitate to pull request. I will definitely respond as soon as possible. Thank you :D
14 stars 7 forks source link

Is it a mistake? #1

Open radiofan opened 2 years ago

radiofan commented 2 years ago

https://github.com/hako-975/PHPExcel-v7.4/blob/f6b598505986502bd3d6d09e10a1e0753fee775f/PHPExcel/Cell/DefaultValueBinder.php#L82

Original is } elseif ($pValue{0} === '=' && strlen($pValue) > 1) {

I think should be } elseif ($pValue[0] === '=' && strlen($pValue) > 1) { or } elseif (is_string($pValue) && $pValue[0] === '=' && strlen($pValue) > 1) {

longware commented 11 months ago

yes