hako-mikan / sd-webui-traintrain

LoRA training extention for Stable Diffusion Web-UI
GNU Affero General Public License v3.0
131 stars 4 forks source link

Questionable library: invisible-watermark #13

Closed Derjyn closed 2 months ago

Derjyn commented 4 months ago

Why is this library in there? As soon as seeing this included, my assumption is that you are placing your own watermarks on generated content. I hope I'm wrong, but some clarification would be great!

I'll be diving into the source code in the meantime, to see if I can figure out why this library is included and how it is being utilized...

Derjyn commented 4 months ago

Update: After diving into the scripts, I'm not seeing any reference to watermarks of any sort. So it seems that library referenced in the install script is unnecessary? I removed the references and library packages, and haven't seen any issues yet.

Might be a little fix/change to make in a future update :)

hako-mikan commented 3 months ago

It seems unnecessary, as you said. It looks like I forgot to remove something that became unnecessary, which was used during the development stage. It was deleted. Thank you.