search

hako / durafmt

:clock8: Better time duration formatting in Go!
MIT License
496 stars 49 forks source link

Add LimitFirstN() method to fine tune output. #15

Closed hoveychen closed 5 years ago

hako commented 5 years ago

Thanks @hoveychen! before I merge this in, could you please improve the coverage by adding tests for this method?

codecov-io commented 5 years ago

Codecov Report

Merging #15 into master will decrease coverage by 2.59%. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #15     +/-   ##
========================================
- Coverage     100%   97.4%   -2.6%     
========================================
  Files           1       1             
  Lines          69      77      +8     
========================================
+ Hits           69      75      +6     
- Misses          0       1      +1     
- Partials        0       1      +1
Impacted Files Coverage Δ
durafmt.go 97.4% <100%> (-2.6%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 650ed9f...362ecc1. Read the comment docs.

hako commented 5 years ago

LGTM 👍