search

hakolao / egui_winit_vulkano

Egui gui integration with winit and vulkano
Apache License 2.0
78 stars 36 forks source link

Paint callbacks #33

Closed Past9 closed 1 year ago

Past9 commented 1 year ago

I took a stab at implementing paint callbacks. Rendering is a bit outside my normal wheelhouse so I'm not sure if this is the best approach, but I'm happy to make adjustments.

cargo run --example triangle
hakolao commented 1 year ago

Thanks! I’ll try to get a look at this tomorrow

Past9 commented 1 year ago

Thanks for the review! Made those changes.

hakolao commented 1 year ago

Looks like the clippy still failed @Past9, might be that you were running it on old rust version. Do rustup update and fix the error, then retry?

Past9 commented 1 year ago

I made the fix that the workflow log is asking for.

Unfortunately I can't run clippy on nightly at the moment due to a compiler bug when building vulkano-shaders on Windows, and I don't have a linux installation at the moment. But hopefully this fix will satisfy clippy.

Past9 commented 1 year ago

The last run failed to download python on both Windows and Linux. I'm assuming this is just an intermittent thing and would probably succeed on another run? I don't see anything in my PR that should cause that issue.

hakolao commented 1 year ago

I’ll try to figure out the CI later today.