search

hakolao / egui_winit_vulkano

Egui gui integration with winit and vulkano
Apache License 2.0
79 stars 40 forks source link

Updated egui to 0.23. #49

Closed Letronix624 closed 1 year ago

hakolao commented 1 year ago

Amazing, remember to run the cargo fmt with nightly: cargo +nightly fmt, because I use some formatting rules that only work there. (rustfmt.toml).

Letronix624 commented 1 year ago

I found the reason! (After some long time just going through my changes) As you suspected the problem originates from the newest version of either Egui or it's demo crate. What should we do? Keep the version of Egui on 0.22 or accept living with the 0.23 problem?

hakolao commented 1 year ago

Maybe accept living with it then.

hakolao commented 1 year ago

Hey, apologies. #50 just went through with lints etc. I was hoping if you could update this PR to just update the egui library? Then we can make a new release

aedm commented 1 year ago

Hey, apologies. #50 just went through with lints etc. I was hoping if you could update this PR to just update the egui library? Then we can make a new release

My bad, I totally missed this PR when I started mine. :( Sorry!

Letronix624 commented 1 year ago

oops. I forgot about the lints because I don't have them set up the same way.

I'm going to do that later today.

hakolao commented 1 year ago

oops. I forgot about the lints because I don't have them set up the same way.

I'm going to do that later today.

No rush!

Letronix624 commented 1 year ago

oops